Commit Diff

Commit:
54b9bba0082407cae6f2ed07376ef1cc8fa01d5a
From:
int16h <int16h@gmail.com>
Date:
Message:
TODO: var improvements; check exit status of execve commands; etc
Actions:
Patch | Tree
commit - c2f7c557cc05d3a0c24373dc0cb02e906a6fe915
commit + 54b9bba0082407cae6f2ed07376ef1cc8fa01d5a
blob - 17a4448cb615c3b108175e8445243693e34474a8
blob + edaa5ba619601ad9f26c8bdd573122c1684d3737
--- TODO.md
+++ TODO.md
@@ -1,3 +1,7 @@
 - ````getconf _NPROCESSORS_CONF```` to determine number of processors is now POSIX, use it where available (thanks to monkfish from #perl)
 - Linux: *-release handling by trying ````/etc/os-release```` for ````NAME```` and/or ````PRETTY_NAME definitions```` ([FreeDesktop::Systemd::os-release](https://www.freedesktop.org/software/systemd/man/latest/os-release.html)) / monkfish
- 
\ No newline at end of file
+- don't 'use vars', prefer lexically scoped variables. where a global is genuinely needed, using 'my' in file scoope is fine (monkfish)
+- Improve variable names (monkfish)
+- chomp and readpipe in one go, e.g. chomp(my $stdout = qx{ ... }); (monkfish)
+- Check actual exit status of commands, if $? != 0 following readpipe, something went wrong. (monkfish)
+- or skip the pipe - tail and read the last line with perl (thrig)
\ No newline at end of file